fix simple report : use untaxed amounts #29218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederic34
reviewed
Apr 3, 2024
| if (!empty($cum[$caseprev]) && !empty($cum[$case])) { | ||
| $percent = (round(($cum[$case] - $cum[$caseprev]) / $cum[$caseprev], 4) * 100); | ||
| //print "X $cum[$case] - $cum[$caseprev] - $cum[$caseprev] - $percent X"; | ||
| if (!empty($cum_ht[$caseprev]) && !empty($cum_ht[$case])) { |
There was a problem hiding this comment.
@rycks can you rename cum to cumulative 🙄
There was a problem hiding this comment.
@frederic34 for sure i could do it but i don't know why ? could you please explain it to me (in private mail if that's something embarrassing)
There was a problem hiding this comment.
see translation of cum... in french
There was a problem hiding this comment.
and ... that's a remake of weboob story ?
excuse-me but if we have to change all variables names that could be misinterpreted we could have a lot of work "for nothing" ...
There was a problem hiding this comment.
Le me do an other PR for that but after merge current PR to avoid collisions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details on french forum
https://www.dolibarr.fr/forum/t/baser-le-calcul-du-rapport-chiffre-daffaires-facture-sur-le-ht/45974
Most important part thanks to Philazerty
Définition - Chiffre d'affaires | Insee https://www.insee.fr/fr/metadonnees/definition/c1703
Le chiffre d'affaires représente le montant des affaires (hors taxes) réalisées par une unité statistique (entreprise, unité légale) avec les tiers dans l'exercice de son activité professionnelle