New - updated discount splitting function in Remx.php #29517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow input the first smaller amount, either in main currency or original currency.
eldy
added
PR to fix - Continuous Integration Test failed
|
Relocate the split icon to besides the amounts (both main currency and original currency) The split confirmation will pop up and user can input the first value he wants, the second value will be calculated automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW
The existing discount splitting function needs to manually input the two smaller amounts in main currency. When user changes one of the amounts, the other one is not auto calculated.
The proposed change allows key in only one amount, either in main currency or original currency and the discount will be split into two discounts accordingly.
The splitting icon will be shown besides the TTC amount in main currency and that in original currency, respectively to different the splitting in either main currency or original currency.