FIX: vat management for credit notes (and negative quantities) #5380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: find why total_vat is stored in absolute value in invoice table |
|
i got it ! when you edit a credit note line, if you put a positive price, this price is converted to negative but vat remains positive ! |
altairis-tof
changed the title
eldy
added
the
Priority - High / Blocking
| $this->line->total_tva = $total_tva; | ||
| $this->line->total_localtax1 = $total_localtax1; | ||
| $this->line->total_localtax2 = $total_localtax2; | ||
| $this->line->total_tva = (($this->type==self::TYPE_CREDIT_NOTE||$qty<0)?-abs($total_tva):$total_tva); // For credit note and if qty is negative, total is negative |
There was a problem hiding this comment.
Fix into function addline looks good to me. However this part seems to be here to manage corrupted data in base due to old bug ? Right ? If i am right, it should be fixed by a sql request and not into core code. For example by adding the sql that fix data into file repair.sql
eldy
removed
the
Priority - High / Blocking
|
i disagree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in vat reports, vat was positive even if total_ht was negative, so vat reports were false (case of credit notes)