Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a case to display mobile icon #6616

Closed
wants to merge 1 commit into from

Conversation

dolibarr95
Copy link
Contributor

@dolibarr95 dolibarr95 commented Mar 30, 2017

Display object_phoning or object_phoning_fax or object_phoning_mobile png icon
I've create the 16*16 object_phoning_mobile.png file but i can't push it into dolibarr/theme/eldy/img (maybe rights access).
i will change dolibarr/core/class/commonobject.class.php ->getBannerAddress() too.

Display object_phoning or  object_phoning_fax or  object_phoning_mobile png icon
I've create the 16*16 object_phoning_mobile.png file but i can't push it into dolibarr/theme/oneblow/img (maybe rights access)
if($withpicto){
if($withpicto=='fax'){//should we use switch case instead ?
$picto = 'phoning_fax';
}elseif($withpicto=='phone'){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why creating a new icone for standard phone ? Just keep current one

Copy link
Contributor Author

@dolibarr95 dolibarr95 Apr 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi
I don't want to create a new one for stantard phone (in this case i use the object_phoning.png picture). I've just want to add the object_phoning_mobile.png $picto = 'phoning_mobile'.

@eldy
Copy link
Member

eldy commented Mar 31, 2017

dir dolibarr/theme/oneblow does not exists.
You must add icon into theme eldy and md.

@eldy eldy added the PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do) label Mar 31, 2017
Copy link
Contributor Author

@dolibarr95 dolibarr95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
I've done a error in my description text i want to add in : dolibarr/theme/eldy/img but i can't :
screencapture-github-dolibarr-dolibarr-upload-develop-htdocs-theme-eldy-img-1491201179857

Here is the file i want to add :
object_phoning_mobile

And the svg file in a zip if you want to edit :
object_phoning_mobile.zip

tks

if($withpicto){
if($withpicto=='fax'){//should we use switch case instead ?
$picto = 'phoning_fax';
}elseif($withpicto=='phone'){
Copy link
Contributor Author

@dolibarr95 dolibarr95 Apr 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi
I don't want to create a new one for stantard phone (in this case i use the object_phoning.png picture). I've just want to add the object_phoning_mobile.png $picto = 'phoning_mobile'.

@eldy
Copy link
Member

eldy commented Apr 29, 2017

I can't see the image object_phoning_mobile.png into the PR.

@dolibarr95
Copy link
Contributor Author

Hi
As I said before i would like to push this png on Dolibarr but i don't know how to do it.
tks

dolibarr95 added a commit to dolibarr95/dolibarr that referenced this pull request Jun 6, 2017
@dolibarr95
Copy link
Contributor Author

Hi

I can push only on my fork :
https://github.com/dolibarr95/dolibarr/blob/develop/htdocs/theme/eldy/img/object_phoning_mobile.png
Please tell me how to push here.

Tks

@dolibarr95 dolibarr95 closed this Jun 6, 2017
@dolibarr95
Copy link
Contributor Author

Closed by error sorry

@dolibarr95 dolibarr95 reopened this Jun 6, 2017
@eldy eldy closed this Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants