Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6075 Balance being miscalculated #7048

Closed
wants to merge 1 commit into from

Conversation

IonAgorria
Copy link
Contributor

And probably fixes #6515 too (not sure)
The bug is that the base balance for the first line in the list is obtained by doing a sum of previous records that are previous date value than first line in list.
It works except when there are several records in the same day and the list is split between records of same day, the records previous than current line but same day are not accounted in balance, the solution is to loop the remaining records in the day to get the proper balance

@braito4
Copy link
Contributor

braito4 commented Jun 22, 2017

👍

@eldy
Copy link
Member

eldy commented Jun 24, 2017

Thanks for analysis and solution.
I pushed a more complete fix. Because, the sort is done on datev, dateo, rowid, we must keep the same 3 fields to find what are the previous record.

@eldy eldy closed this in e79f371 Jun 24, 2017
@IonAgorria IonAgorria deleted the fix-bank-lines branch June 24, 2017 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Balance in bankentries.php does not match statement
3 participants