FIX transfer of line extrafields from order to invoice #7333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Sep 7, 2017
htdocs/fourn/facture/card.php
Outdated
| // Extrafields | ||
| if (empty($conf->global->MAIN_EXTRAFIELDS_DISABLED) && method_exists($lines[$i], 'fetch_optionals')) { | ||
| require_once DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php'; | ||
| $extrafields = new ExtraFields($db); |
There was a problem hiding this comment.
Because var $extrafields is already defined globally previously, it looks dangerous to use same name here.
If you rename into extrafieldsforlines, does you fix still work ?
eldy
added
the
PR to fix or conflict to solve
|
Rename done and tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.