NEW Enable auto update PDF on update note #9018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate order/invoice PDF on update public note
eldy
reviewed
Jun 29, 2018
| @@ -2511,6 +2511,27 @@ function update_note($note,$suffix='') | |||
| $this->note = $note; // deprecated | |||
| $this->note_private = $note; | |||
| } | |||
| if($suffix != '_private' && in_array($this->table_element, array('commande_fournisseur', 'commande', 'propal', 'facture_fourn', 'facture' ))){ | |||
There was a problem hiding this comment.
The "update_note" method is a CRUD method to affect the database values. I would prefer to see code to build PDF that is not related with DAO principle after the call of update_note
eldy
added
the
PR to fix or conflict to solve
|
I can transfer code into "htdocs/core/actions_setnotes.inc.php", Ok ? |
|
Yes, good idea. |
eldy
reviewed
Aug 13, 2018
htdocs/core/actions_setnotes.inc.php
Outdated
| $hidedetails = (GETPOST('hidedetails','int') ? GETPOST('hidedetails','int') : (! empty($conf->global->MAIN_GENERATE_DOCUMENTS_HIDE_DETAILS) ? 1 : 0)); | ||
| $hidedesc = (GETPOST('hidedesc','int') ? GETPOST('hidedesc','int') : (! empty($conf->global->MAIN_GENERATE_DOCUMENTS_HIDE_DESC) ? 1 : 0)); | ||
| $hideref = (GETPOST('hideref','int') ? GETPOST('hideref','int') : (! empty($conf->global->MAIN_GENERATE_DOCUMENTS_HIDE_REF) ? 1 : 0)); | ||
| require_once DOL_DOCUMENT_ROOT.'/fourn/class/fournisseur.product.class.php'; |
There was a problem hiding this comment.
I don't understand why.
There is no dedicated code to supplier product added by the PR, so why adding this ? The require is surely at the wrong place.
eldy
added
the
PR OK to merge
eldy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate order/invoice PDF on update public note