Deleting elements for sites where the redirect should not exist. Keep…

…ing this in the afterSave callback will have it run for each time the records are saved on the sites.
Dolphiq · Aug 1, 2019 · 8ffafa9 · 8ffafa9
1 parent 4874513
commit 8ffafa9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/src/controllers/SettingsController.php b/src/controllers/SettingsController.php
@@ -351,6 +351,15 @@ public function actionSaveRedirect()
 
             return null;
         } else {
+          // remove form other sites
+          Craft::$app->getDb()->createCommand()
+            ->delete('{{%elements_sites}}', [
+              'AND',
+              ['elementId' => $redirect->id],
+              ['!=', 'siteId', $siteId]
+            ])
+            ->execute();
+
             if ($request->getAcceptsJson()) {
                 return $this->asJson([
                     'success' => true,

diff --git a/src/elements/Redirect.php b/src/elements/Redirect.php
@@ -346,14 +346,6 @@ public function afterSave(bool $isNew)
 
         $record->save(false);
 
-        // remove form other sites
-        Craft::$app->getDb()->createCommand()
-            ->delete('{{%elements_sites}}', [
-                'AND',
-                ['elementId' => $record->id],
-                ['!=', 'siteId', $this->siteId]
-            ])
-            ->execute();
         parent::afterSave($isNew);
     }