Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add needsRehash function #51

Open
pinoy4 opened this issue Aug 23, 2016 · 3 comments
Open

Add needsRehash function #51

pinoy4 opened this issue Aug 23, 2016 · 3 comments

Comments

@pinoy4
Copy link

pinoy4 commented Aug 23, 2016

I believe it would be very convenient to have a function that evaluates whether a password's hash has been generated using lower costs that the current implemented ones. I like to store my costs in a configuration file so that if I am to upgrade my machine's hardware I can increase the cost easily, this way maintaining my new hashes updated with the latest machine power. I also like to update old hashes when they were generated with lower costs so if a password is verified I'll go through this check. I already have implemented this function in my local scrypt.php file and if you agree this is a good idea I would like it to be implemented on your repo.

@beyonderyue
Copy link

Hi,
Can you submit your PRs to https://github.com/beyonderyue/php-scrypt ?
Thank you.

@pinoy4
Copy link
Author

pinoy4 commented Dec 12, 2017

Hi, I'm not really sure this is very relevant to php anymore since the added crypto functionalities in newer php versions. If you insist I could still take a look at what I did back then and make a PR

@beyonderyue
Copy link

@pinoy4 when you submit this PR, you can tell me the PHP version.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants