Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

password gui with pinentry-mac for handling Casks that require sudo #110

Merged
merged 13 commits into from
Nov 11, 2023

Conversation

swissbuechi
Copy link
Contributor

Solves Issue #40

You can now pass the argument --sudo to the start command.
If a Cask requires sudo, pinetry-mac will open a gui to ask for the password:
image

@swissbuechi
Copy link
Contributor Author

The users currently need to manually run brew install pinentry-mac.
Should I add a check if pinentry-mac is installed and display a hint to the users? (Only if the --sudo argument is used)
Or should we auto-install the dependency if it is missing?

README.md Show resolved Hide resolved
@MikeMcQuaid
Copy link
Contributor

Should I add a check if pinentry-mac is installed and display a hint to the users? (Only if the --sudo argument is used)
Or should we auto-install the dependency if it is missing?

Up to @DomT4 but I think at least it should check in the code.

@swissbuechi
Copy link
Contributor Author

swissbuechi commented Oct 27, 2023

The window spawned by pinentry-mac steals the focus, and also you can not minimize it.
I will look into the docs, maybe there is an option to enable the minimize button.

@swissbuechi
Copy link
Contributor Author

The window spawned by pinentry-mac steals the focus, and also you can not minimize it. I will look into the docs, maybe there is an option to enable the minimize button.

Focus: --no-global-grab option is already set 👍🏻
Minimize: This is currently not possible with pinentry-mac

@DomT4
Copy link
Owner

DomT4 commented Oct 31, 2023

This is good work, thank you @swissbuechi. Sort of held off moving on this broader issue because I was trying to think of something both native and lightweight, and never really found anything I was happy with. Agree this is at least better than the status quo and a very visible improvement to the end user.

Will give this another glance over no later than Wednesday but from quick glance it looks like a better workaround than anything I've cooked up 😄.

Thanks for the code review @MikeMcQuaid 🙌🏻

@swissbuechi
Copy link
Contributor Author

swissbuechi commented Nov 10, 2023

This is good work, thank you @swissbuechi. Sort of held off moving on this broader issue because I was trying to think of something both native and lightweight, and never really found anything I was happy with. Agree this is at least better than the status quo and a very visible improvement to the end user.

Will give this another glance over no later than Wednesday but from quick glance it looks like a better workaround than anything I've cooked up 😄.

Thanks for the code review @MikeMcQuaid 🙌🏻

@DomT4 thank you 👍🏻
I'm looking forward to your review.

A litte bit off-topic, but could you please unlock issue: #59 ?
I would like to discuss this and maybe create another PR to provide an option to use StartCalendarInterval.
Maybe you also need to add some labels, so the bot won't auto-close it again.

Thanks.

@MikeMcQuaid
Copy link
Contributor

A litte bit off-topic, but could you please unlock issue: #59 ?

@swissbuechi done, hope that's ok @DomT4, feel free to re-lock if not and: sorry!

@DomT4 DomT4 merged commit c70c2bc into DomT4:master Nov 11, 2023
1 check passed
@swissbuechi swissbuechi mentioned this pull request Nov 11, 2023
@swissbuechi swissbuechi deleted the add-sudo-gui branch November 13, 2023 14:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants