[v7.0.2] Crop can move on resize and goes beyond boundaries. #261
Comments
|
Hi thanks for the clear bug report 👍 Please try 7.0.3 |
|
@de83c78d1f any luck? |
|
Thank you for fast response/fix. Yeah, new version actually fixes the bug mentioned above. |
|
Ah good catch thanks for checking will take a look soon |
|
@de83c78d1f Finally getting round to look at this, can you try with this sandbox https://codesandbox.io/s/reactimagecrop-issue-261-qq72y or else spot if I'm doing something wrong?: I have set same min/max as you and 16/9 aspect, but crop isn't growing on the other side:
I can see from your screen you're on the same version so I'm guessing I'm doing something wrong in replicating it. |
|
Edit: ignore, I can reproduce some of the time |
|
This should be fixed in #7.0.5 now |
* Allow crop to be interchangeable pixels or percentage * Upgrade build tooling to webpack 4, babel 7 * Add doc on unit * Bugfixes of v8 functionality * Fix a couple of points in README * Fix x/y position when drawing a new crop * Internal change: change resolveCrop to also only accept image dimensions * Fix onComplete hash link * Fix issue #261 * Run build * Run build * Render both px or pc (dont convert pc to px for render) * Build v8
|
Hi, all fixes are irrelevant after version 8. Library does not respect boundaries anymore. Nor it respects min dimensions. |
|
Ping |
|
I'm aware of the bug, I looked into it but didn't find a fix easily. I'm
working on multiple other things at the moment so don't know when I'll next
delve into it. If I recall JCrop didn't have the issue so you could use
that if you prefer
…On Wed, Aug 28, 2019 at 12:01 PM de83c 78d1f ***@***.***> wrote:
Ping
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#261>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFZT6WSMXMOHMGU2HL2YQTQGZLKDANCNFSM4HOHYAXA>
.
|
|
Fixed in 8.4.0 |
Hello, there is issue when u have min dimensions. Assume we have crop component with minWidth/minHeight 160/90px (add those props to ReactCrop component). If you drag your crop to bottom of canvas leaving some space to enlarge crop to bottom. Then drag bottom-left corner to the bottom edge of the canvas and keep dragging.
It is reproducible in demo.
Although checking on crop x position in onCropChange is an option - there's still an issue 1 - crop kinda shouldn't move while user attempts to resize.
The text was updated successfully, but these errors were encountered: