Skip to content

Commit

Permalink
[bare-expo] Fix start-metro script on Linux
Browse files Browse the repository at this point in the history
  • Loading branch information
DominickVale committed Nov 8, 2021
1 parent 0b44d89 commit d0c5640
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ Manual smoke tests are included in `apps/native-component-list`, this is a good
- iOS: `yarn ios`
- Android: `yarn android`

If you are working on a Linux distribution, make sure to set the `TERMINAL` environment variable to your preferred terminal application. (e.g. `export TERMINAL="Konsole"`)

8. You are now running the `test-suite` app via the `bare-expo` project. The next section explains how you can begin to make changes to SDK packages.

> If this didn't work for you as described, please [open an issue.](https://github.com/expo/expo/issues/new/choose)
Expand Down
13 changes: 11 additions & 2 deletions apps/bare-expo/scripts/start-metro.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,15 @@ yarn start --port ${port}
EOF
# execute the file in a new command line window
chmod 0755 ${commandFile}
open ${commandFile}

case "$OSTYPE" in
darwin*)
open ${commandFile}
;;
*)
# Spawns a new terminal window and detaches it
# Assuming the non-standard variable $TERMINAL is set
nohup "$TERMINAL" -e "${commandFile}" </dev/null >/dev/null 2>&1 &
;;
esac

fi

0 comments on commit d0c5640

Please sign in to comment.