Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flickr-icon #103

Merged
merged 1 commit into from
May 19, 2014
Merged

fix flickr-icon #103

merged 1 commit into from
May 19, 2014

Conversation

ingwinlu
Copy link
Contributor

adds functionality to use social icons that don't use the square notation, see issue #86

  • implemented flickr fix

flickr_fix

@DonDebonair
Copy link
Owner

See my comment in your commit, I think you've missed something :)

@ingwinlu
Copy link
Contributor Author

sorry i force pushed a new one which deleted it

what did i forget?

@DonDebonair
Copy link
Owner

The dash between name_sanitized and square.

@ingwinlu
Copy link
Contributor Author

thanks @dandydev, added the dash now

DonDebonair added a commit that referenced this pull request May 19, 2014
@DonDebonair DonDebonair merged commit 33e3ec5 into DonDebonair:master May 19, 2014
@DonDebonair
Copy link
Owner

Great work @ingwinlu, thanks!

@DonDebonair DonDebonair mentioned this pull request May 19, 2014
@ingwinlu ingwinlu deleted the social_icon_fix branch May 19, 2014 14:49
@ingwinlu ingwinlu restored the social_icon_fix branch May 19, 2014 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants