Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For pull #37

Closed
wants to merge 2 commits into from
Closed

For pull #37

wants to merge 2 commits into from

Conversation

tao-guo
Copy link
Contributor

@tao-guo tao-guo commented Jan 10, 2014

With these two changes, generated site can even be opened locally from index.html.

@DonDebonair
Copy link
Owner

According to the 3.3.0 docs, TAGS_URL and CATEGORIES_URL have defaults already. However, according to the latest docs those settings don't exist anymore, and it's actually advised to put the urls hardcoded in the theme. I'm not sure yet what to do with this.

Regarding the second commit: This shouldn't be necessary. If you run make serve and the SITEURL is properly set (SITEURL = 'http://localhost:8000') then the link will work. It does with me, anyways :)

@DonDebonair
Copy link
Owner

Also, please split different issues in different PRs, on different branches :)

@magnunleno
Copy link
Contributor

Actually Pelican 3.3.0 has a bug that TAGS_URL and CATEGORIES_URL doesn't honor it's default value. I've opened an issue recently: getpelican/pelican#1216

This PR is valid but not for long term. Maybe is better to keep an alert in the README telling to force the TAGS_URL and CATEGORIES_URL in the pelican.conf until the next pelican release.

@DonDebonair
Copy link
Owner

Actually, CATEGORIES_URL and TAGS_URL are both gone from the latest Pelican docs. TAGS_URL was still present in the 3.3.0 version. See this issue I created: getpelican/pelican#1225

@magnunleno
Copy link
Contributor

There is something really strange going on. The issue I linked before was closed by a pull request to pelican's master branch. Let's wait the response from your issue.

@justinmayer
Copy link

@magnunleno: It's not that mysterious. Your issue was closed automatically by the pull request that fixed it. Then, a subsequent PR reverted that fix. We'll sort it out in the issue Daan filed.

@magnunleno
Copy link
Contributor

@justinmayer Thanks!

@hlapp
Copy link
Contributor

hlapp commented Jan 12, 2014

@tao-guo see pull request #15 and issue #14. This has already been fixed.

@tao-guo
Copy link
Contributor Author

tao-guo commented Jan 12, 2014

Thanks for the replies. What I mean is another issue: I was always opening the index.html local file with firefox/chrome directly, and I would get a well organized website even without any httpd server. To make it work,
I also set SITEURL to be empty and RELATIVE_URLS to be true. I am not sure if it is a normal case for most people, but it seems a good way for me to organize my local documents.

Thanks,
-Tao

@hlapp
Copy link
Contributor

hlapp commented Jan 12, 2014

@tao-guo a lot of the bootstrap theme won't work if not serving over HTTP, due to JavaScript. If you want something that works for file:// access, have you looked at the simple theme built into Pelican?

@tao-guo
Copy link
Contributor Author

tao-guo commented Jan 12, 2014

Yes, the "simple" theme has the same issue. It will get "directory list" mode when clicking site link. Anyway it is not a big problem, maybe you can just ignore it.

Thanks,
-Tao

@DonDebonair
Copy link
Owner

The TAGS_URL and CATEGORIES_URL is something that needs to be looked at, but it depends on the aforementioned Pelican issue. The rest I won't merge, because its not an issue IMHO :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants