Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace channels_info with conversations_info #386

Conversation

repudi8or
Copy link
Contributor

As of slack-machine v0.20 release i am getting :-
[2020-07-23 01:23:44][ERROR] slack.rtm.client client.py:_dispatch_event:505 | When calling '#_on_channel_created()' in the 'machine.clients.singletons.slack' module the following error was raised: The request to the Slack API failed.
The server responded with: {'ok': False, 'error': 'method_deprecated', 'response_metadata': {'messages': ['[ERROR] This method is retired and can no longer be used. Please use conversations.info instead. Learn more: https://api.slack.com/changelog/2020-01-deprecating-antecedents-to-the-conversations-api.']}}

This PR moves the calls from channels_info to conversations_info and makes a bunch of model fields optional that slack does not return in some cases

@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #386 into master will not change coverage.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #386   +/-   ##
=======================================
  Coverage   76.09%   76.09%           
=======================================
  Files          23       23           
  Lines         916      916           
=======================================
  Hits          697      697           
  Misses        219      219           
Impacted Files Coverage Δ
machine/clients/singletons/slack.py 43.00% <0.00%> (ø)
machine/models/user.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13b4563...15563d1. Read the comment docs.

@DonDebonair
Copy link
Owner

Huh, that's interesting. I've actually tested v0.20 yesterday, thoroughly. I have a sort of manual test procedure with a bunch of test-plugins that I run through on a Slack workspace created specifically for testing Slack Machine. These issues didn't come up.
The only thing I can think of is that Slack lets different workspaces use different versions of their API, based on the token.

In any case, thanks, I wil merge it now and cut a release later today.

@DonDebonair DonDebonair merged commit 8897bc7 into DonDebonair:master Jul 23, 2020
@repudi8or
Copy link
Contributor Author

repudi8or commented Jul 23, 2020 via email

@DonDebonair
Copy link
Owner

v0.20.1 has been published.

@DonDebonair
Copy link
Owner

Are you ok with contributions in that manner (via PR from my fork)? There have been a few issues that i have commented on, and waited for your fix, although i could have done so and saved you the effort. Im building some things that are close to the feature requests others have made so if thats cool, i will just keep following that PR process. Rep

Absolutely! Be aware that I can be picky though, about what features I want to be in the core and not, and also about code style.
And due to limited time, it can take a while before I can review PRs. But they're very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants