Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependency #34

Closed
tomsaleeba opened this issue Dec 3, 2019 · 0 comments
Closed

Circular dependency #34

tomsaleeba opened this issue Dec 3, 2019 · 0 comments

Comments

@tomsaleeba
Copy link

When you run the npm run build process, there's a warning:

(!) Circular dependency: lib/index.js -> lib/web-worker.js -> lib/index.js

There's already the import compress from './image-compression' that seems to do most of the heavy lifting and it's not like the web-worker is ever going to call another web-workers, which is possible in the current configuration. Perhaps extract the core of the runner and have index.js and web-worker.js both use that new core?

This doesn't seem to break things BTW, it's just a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants