Sorting #99
Merged
Sorting #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Donkie
commented
Sep 8, 2023
•
Donkie
commented
- Allow multiple filament name filter selects
- Filter by empty
- remaining_weight sort
- Filter by multiple materials etc
- Don't load materials etc so often
- Contract tests
Previously you used underscore, like vendor_name. This made fields like filament_article_number have ambiguous underscores.
Still some stuff left to do #98
Also added tests for having multiple sorts
Fixed issue with incorrect total count for vendors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.