You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As of mod version 1.0.11 for Minecraft 1.16.5, losing EMC over time shows two minus signs in front of the number, like below:
To reproduce:
Use a Transmutation Table or something similar to put in some items.
Wait 5 seconds.
Use a Transmutation Table or similar to take out many items.
Notice that the EMC display shows you are losing EMC, but with 2 minus signs instead of 1.
To reproduce with larger numbers, which cause the number to not be shortened when required:
emc set @s 1000000000000
Wait 5 seconds
emc set @s 100000000000
Notice that the EMC display shows you are losing EMC, but the number is not formatted.
This may be caused by the following line of code prepending a negative sign to a negative number that formats to a string generated by the EMCFormat.INSTANCE.format function which already contains a leading negative sign:
Pretty sure I even saw this issue while fixing #15 and just paid no mind to it, this seems like an easy fix that I should be able to get done once I'm back at home later
The number format breaking for negative numbers is because the format function does not check that the number is negative before formatting the number.
As of mod version 1.0.11 for Minecraft 1.16.5, losing EMC over time shows two minus signs in front of the number, like below:
To reproduce:
To reproduce with larger numbers, which cause the number to not be shortened when required:
emc set @s 1000000000000
emc set @s 100000000000
This may be caused by the following line of code prepending a negative sign to a negative number that formats to a string generated by the
EMCFormat.INSTANCE.format
function which already contains a leading negative sign:ProjectExpansion/src/main/java/cool/furry/mc/forge/projectexpansion/gui/EMCDisplay.java
Line 67 in 3ad2f6f
The text was updated successfully, but these errors were encountered: