Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.31] EMC (Item) Links Reporting Incorrect Number of Items #66

Closed
Timeslice42 opened this issue Jul 23, 2022 · 10 comments
Closed

[1.0.31] EMC (Item) Links Reporting Incorrect Number of Items #66

Timeslice42 opened this issue Jul 23, 2022 · 10 comments
Labels
bug Something isn't working Fixed The issue has been fixed. non-priority

Comments

@Timeslice42
Copy link

Timeslice42 commented Jul 23, 2022

Version .31 is not reporting the correct number of items for EMC links to other storage mods (such as AE2). In version .26 (or maybe it was .24?) the link would report the amount as the number of items that could be supplied given your current EMC. While not correct, it was at least usable. In the current version it is always reporting the amount as 1, which is definitely not usable for automated crafting.
Specifically, in my case, I'm using an AE2 storage bus on an EMC (item) Link.

Ideally the reported value should be the lesser of TotalEMC/ItemEMC or the item limit for the EMC Link in question.

The Transmutation Interface seems to be working fine.

[Edit] The version of AE2 did not change between these two scenarios.

@DonovanDMC
Copy link
Owner

DonovanDMC commented Jul 23, 2022

The emc link isn't what should be connected to the storage bus, that's the Transmutation Interface. The emc link is reporting an incorrect inventory count, that will be fixed, but it will take a while to make it into a release.

@DonovanDMC DonovanDMC added the bug Something isn't working label Jul 23, 2022
@DonovanDMC DonovanDMC added the pending release Issues that are waiting for a release to be finalized label Jul 23, 2022
@Timeslice42
Copy link
Author

If I could craft the transmutation interface I'd obviously be using the interface. :P
Rolling back to .27, the version before Fluid Links should fix the issue, right?

@DonovanDMC
Copy link
Owner

I.. wouldn't really recommend purposely downgrading, especially that far, but sure

This came from some code cleanup in 1.0.28
d7c990b#diff-22fc7281f10f979f36281bff93afd19635b9ef30c779bceeafdc6f5c3554c8ccR190

You'll be missing out on these, and more

  • emc link fluid handling
  • another bug with emc links that was fixed in 1.0.29
  • the alchemical collection enchantment
  • the knowledge sharing be

@Timeslice42
Copy link
Author

Yeah, as it stands half of my auto-crafting is busted, so my choices are re-engineer the whole thing, or roll back to the version that I was using up until my previous session. Since I'm maybe 20 hours away from being able to craft the transmutation interface, re-engineering a system that's going to be replaced didn't appeal to me.
I'll definitely be returning to latest once I do that though. Thank you for your help!

@DonovanDMC
Copy link
Owner

DonovanDMC commented Jul 23, 2022

If you don't mind running a dev build, I could whip one of those up quickly

it shouldn't be noticeably different, but I won't be publishing a new version for at least another week or until another bug comes through

@Timeslice42
Copy link
Author

That would be just fantastic. Are we talking tons of log spam, or just a version I'll have to manually install as opposed to using curseforge?

@DonovanDMC
Copy link
Owner

Should just be the latter, it's still a normal build, just tagged differently

@Timeslice42
Copy link
Author

I'm off now, but I'll check this issue again in the morning. Thanks for helping me out.

@DonovanDMC
Copy link
Owner

Build's been made, it'll be shown as 1.16.5-1.0.32-dev.20220723a

I can't attach jars here, so I've uploaded it under a directory on one of my sites
https://furry.cool/tmp/ProjectExpansion-1.16.5-1.0.32-dev.20220723a.jar

do note that any bugs noticed with this version should be reproduced in a non-development version before reporting

@DonovanDMC DonovanDMC added Fixed The issue has been fixed. and removed pending release Issues that are waiting for a release to be finalized labels Aug 6, 2022
@DonovanDMC
Copy link
Owner

Fixed in latest releases
1.15: 1.0.31
1.16: 1.0.32
1.18: 1.0.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed The issue has been fixed. non-priority
Projects
None yet
Development

No branches or pull requests

2 participants