Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add System enum to give more detailed hardware/os information #141

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

shadycuz
Copy link
Member

@shadycuz shadycuz commented Oct 29, 2021

The Platform class now returns a System enum instead of a String like UNIX or WINDOWS. The System enum now provides things like the architecture, distribution name and shell.

I have updated the Platform.architecture and Platform.getShell methods to use the new System enum. There is still a lot of overlap between the two and I'm not sure what I will do in the future. It seems like right now, Platform's only real use is to construct the System enum and to set the default shell. it is likely in the future I remove Platform and move it's responsibilities to jenkins.Instance or jenkins.Build.

Another change was instead of getting the architecture from uname, I'm getting it from java os.arch property.

@shadycuz shadycuz added enhancement New feature or request minor Bumps the minor version. labels Oct 29, 2021
@shadycuz shadycuz merged commit 4c9d6e6 into develop Oct 29, 2021
@shadycuz shadycuz deleted the programs_package branch October 29, 2021 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Bumps the minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant