Add System enum to give more detailed hardware/os information #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Platform
class now returns aSystem
enum instead of a String likeUNIX
orWINDOWS
. TheSystem
enum now provides things like the architecture, distribution name and shell.I have updated the
Platform.architecture
andPlatform.getShell
methods to use the newSystem
enum. There is still a lot of overlap between the two and I'm not sure what I will do in the future. It seems like right now,Platform
's only real use is to construct theSystem
enum and to set the default shell. it is likely in the future I removePlatform
and move it's responsibilities tojenkins.Instance
orjenkins.Build
.Another change was instead of getting the architecture from
uname
, I'm getting it from javaos.arch
property.