Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit stop event. make stop faster by cancelling queued invocations. #13

Merged
merged 3 commits into from
Jan 23, 2017

Conversation

DonutEspresso
Copy link
Owner

@DonutEspresso DonutEspresso commented Jan 21, 2017

Previously, when stop() was called, and we weren't in the user supplied function, it would wait until right before next invocation to check before we stop.

Now, when stop is called, we check to see if we are in user supplied function, and if not, we simply clear the next scheduled invocation and stop immediately.

We also now emit a stop event on completion.

@DonutEspresso
Copy link
Owner Author

cc @rajatkumar @yunong

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a77f3c6 on stop-faster into 5143b2a on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a77f3c6 on stop-faster into 5143b2a on master.

@coveralls
Copy link

coveralls commented Jan 21, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 0329a4d on stop-faster into 5143b2a on master.

@coveralls
Copy link

coveralls commented Jan 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 162ace0 on stop-faster into 5143b2a on master.

@DonutEspresso DonutEspresso merged commit 36b5bd8 into master Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants