New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the APU #111
Open
tcfritchman
wants to merge
58
commits into
Dooskington:master
Choose a base branch
from
tcfritchman:APU-Impl
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement the APU #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r rather than individual values
This is awesome! I was not expecting anybody to pick up the torch and complete this feature. I'll take a look at the code this week, but the demo sounded great. Guess I need to get this thing compiling locally again :) |
AlexKoukoulas2074245K
pushed a commit
to AlexKoukoulas2074245K/GoodBoy
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I came across this project and figured I'd give a go at the audio implementation.
Here are the results: https://www.youtube.com/watch?v=kHrxTst4zVg
Like other aspects of the project, the audio is done using SDL and supports stereo sound just like the Game Boy. For now, the sample rate is fixed at 48kHz.
To verify the behavior, I wrote a test rom which covers most of the APU's features. https://github.com/tcfritchman/gb-tests-apu
Everything was tested on MacOS as well as Windows and Linux.
I know this project isn't very active anymore, but please review and incorporate these changes if you're interested! Regardless, I had a great time doing this implementation and learned a ton about emulation and audio programming, so thank you 🙏