Fix inplace option being always overwritten #22
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observation
I observed that the following action always passes - even after I
added bad indentation on purpose.
For example, the following call always returns an exit code of 0:
The bug
Turns out that
--inplace
was parsed wrong and as soon as--inplace
is passed (and it is always passed) it essentially actually meant
--inplace True
. And when--inplace True
is passed, then the exitcode will be 0 and thus the action always is successful.
See
https://stackoverflow.com/questions/15008758/parsing-boolean-values-with-argparse
for more information on parsing booleans.
Running the above Docker command with my fix actually returns an exit
code of 1 and thus the actions also fails as expected.
Fixes #18. Fixes #19