-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cli args #5
Add cli args #5
Conversation
It's ready for review. |
@gabrieldemarmiesse Sorry for the late response. Thank you for the PR. The run-clang-format script is from another repository (https://github.com/Sarcasm/run-clang-format), I tried adding it as a submodule but it didn't work. There was a similar pull request (Sarcasm/run-clang-format#16) there for this feature but it got closed recently because of inactivity, and I would like the script to stay the same as there for now. If you want you can make the pull request there or I could do it, the major difference is that the author suggested the name to be "extra-arg". |
I opened #8 which just uses the |
Fix #3 (partially)
We needed it in tensorflow/addons You can see this PR where I use the branch in my fork: tensorflow/addons#1012