Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli args #5

Closed

Conversation

gabrieldemarmiesse
Copy link

@gabrieldemarmiesse gabrieldemarmiesse commented Feb 2, 2020

Fix #3 (partially)

We needed it in tensorflow/addons You can see this PR where I use the branch in my fork: tensorflow/addons#1012

@gabrieldemarmiesse
Copy link
Author

It's ready for review.

@DoozyX
Copy link
Owner

DoozyX commented Mar 22, 2020

@gabrieldemarmiesse Sorry for the late response.

Thank you for the PR.

The run-clang-format script is from another repository (https://github.com/Sarcasm/run-clang-format), I tried adding it as a submodule but it didn't work. There was a similar pull request (Sarcasm/run-clang-format#16) there for this feature but it got closed recently because of inactivity, and I would like the script to stay the same as there for now. If you want you can make the pull request there or I could do it, the major difference is that the author suggested the name to be "extra-arg".

@Flamefire
Copy link
Contributor

I opened #8 which just uses the --style option. This is consistent with the open PRs from the mentioned repo and seems to work for @gabrieldemarmiesse (you are only using the --style option aren't you?)

@DoozyX DoozyX closed this in #8 May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please support CLI options to clang-format
3 participants