Fix salus failures #389
Merged
Fix salus failures #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanoogian
force-pushed
the
nic/salus-fix
branch
2 times, most recently
from
afc0920
to
637e29b
Compare
This fixes an error that we were seeing with `cargo-audit`, which we aren't using.
nmanoogian
force-pushed
the
nic/salus-fix
branch
9 times, most recently
from
9b9da2c
to
2b760a2
Compare
nmanoogian
force-pushed
the
nic/salus-fix
branch
2 times, most recently
from
16ec162
to
0ed36cc
Compare
Piccirello
previously approved these changes
Apr 28, 2023
This notice appeared once we fixed the cargo-audit issue.
The latest version doesn't include any relevant fixes or improvements but I made the change during debugging and figured it would be a good change to keep.
Piccirello
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started to notice errors from Salus relating to
cargo-audit, which we don't use, so we now define the specific scanners for Salus to run.The GitHub Action that we're using automatically pulls the latest Salus image which included some semgrep changes that seem to break with our custom rules. For this reason, I've also pulls semgrep into a separate step.