Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few TUI edge cases #426

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Fix a few TUI edge cases #426

merged 3 commits into from
Aug 16, 2023

Conversation

apazzolini
Copy link
Contributor

  • Pressing tab when no secrets existed was causing a panic
  • Launching the TUI prior to doppler setup was opening the TUI with a difficult to spot error message
  • Filtering secrets, editing, and saving was causing focus to be lost

Closes ENG-6765

@apazzolini
chore: fix panic when pressing tab if no secrets are visible
c60b347
@apazzolini
chore: require project to launch the TUI
1f047a0
@apazzolini
chore: focus first visible SVM when secrets change
5c2922c 
Previously, if there was a filter applied that hid the first SVM, we
would incorrectly focus that hidden secret, which would prevent the
ability to select secrets.
@Piccirello Piccirello merged commit ed0b67d into master Aug 16, 2023
23 of 24 checks passed
@Piccirello Piccirello deleted the andre/tui-bugs branch August 16, 2023 22:10
@Piccirello Piccirello mentioned this pull request Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piccirello Piccirello Piccirello approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@apazzolini @Piccirello