Add configure flags command for configuring CLI behavior
#436
Conversation
| if version.PerformVersionCheck && configuration.CanReadEnv { | ||
| enable := os.Getenv("DOPPLER_ENABLE_VERSION_CHECK") | ||
| if enable == "false" { | ||
| logValueFromEnvironmentNotice("DOPPLER_ENABLE_VERSION_CHECK") | ||
| version.PerformVersionCheck = false | ||
| } | ||
| } | ||
| if version.PerformVersionCheck { | ||
| version.PerformVersionCheck = !utils.GetBoolFlagIfChanged(cmd, "no-check-version", !version.PerformVersionCheck) | ||
| } |
There was a problem hiding this comment.
Relocated this logic from loadFlags() since the config file isn't loaded yet when that function runs.
|
Any updates here? The issues this PR closes are ~8 months old, so it would be really great to merge this one in. |
Thanks for the bump, @agilesteel! I'll be taking this PR over and I should have it fixed up and ready to go shortly. |
nmanoogian
force-pushed
the
tom-flags
branch
from
da97602
to
2988555
Compare
nmanoogian
force-pushed
the
tom-flags
branch
9 times, most recently
from
7625fb1
to
775cb77
Compare
nmanoogian
force-pushed
the
tom-flags
branch
from
1dc14f8
to
875de09
Compare
We were getting the following gosec error when using `slices.Contains`: ``` could not import slices (invalid package name: "") ``` This is because: - `slices` was added in Go 1.21 - Support for Go 1.21 was added in gosec 2.17 - We are currently using gosec 2.15.0 and via salus 3.2.5 via federacy/scan-action which pulls `coinbase/salus:latest` Salus 3.2.6 has been released with the gosec version bump but it isn't tagged `latest`. I've filed coinbase/salus#880 to address. For now, the easiest thing to do was just to not use the `slices` module, which was easy because we already have a util which does the same thing.
Updated initially to fix the gosec issue described in the previous commit but it didn't help. Kept the change anyway.
nmanoogian
force-pushed
the
tom-flags
branch
from
875de09
to
e093993
Compare
|
Bro for real we've been waiting for 8 months and you fixed it in 2 days. Epic! 👏🏼 |
Full credit goes to @Piccirello! He parted ways with Doppler before he could get this merged and all that was missing was fixing a small but tricky issue in the tests. The delay since late October is on me; I apologize for that and we have improved our processes to make sure that PRs aren't allowed to sit for this long in the future. |
|
@nmanoogian thank you for getting this over the finish line. I see this capability potentially serving future customization needs, beyond just the several people already asking for it. |
This PR adds the ability to configure various CLI behavior via a new
configure flagscommand. The following flags default totrueand can be disabled viaconfigure flags disableor viasetupwith a validdoppler.yaml.analytics: Whether anonymous analytics are enabled.env-warning: Whether to print a warning when CLI behavior is modified via an environment variable.update-check: Whether to check for CLI updates.Closes ENG-6729, closes #422, closes #407