Skip to content
This repository has been archived by the owner on Dec 30, 2019. It is now read-only.

Production build without "transpileOnly: true" #28

Closed
DorianGrey opened this issue Sep 28, 2018 · 0 comments
Closed

Production build without "transpileOnly: true" #28

DorianGrey opened this issue Sep 28, 2018 · 0 comments
Milestone

Comments

@DorianGrey
Copy link
Owner

With the currently used transpileOnly flag enabled for ts-loader, some issues with the generated code might occur, esp. regarding const enums, like described here:

microsoft/TypeScript#16671
TypeStrong/ts-loader#331

To avoid doing duplicated work, type checking via fork-ts-checker-webpack-plugin should be disabled. However, it cannot be disabled without disabling it at all. If that is the only alternative, externalizing the linting step from the build to a separate task - executable on demand, forcefully executed on pre-commit should be useful. Already did that in some other projects with great success.

@DorianGrey DorianGrey added this to the 20.0.0 milestone Sep 28, 2018
DorianGrey added a commit that referenced this issue Oct 23, 2018
…ot prod builds; disable type checker accordingly; fixes #28.
DorianGrey added a commit that referenced this issue Dec 3, 2018
…ot prod builds; disable type checker accordingly; fixes #28.
DorianGrey added a commit that referenced this issue Dec 24, 2018
…ot prod builds; disable type checker accordingly; fixes #28.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant