Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dynamic user details #22

Merged
merged 4 commits into from May 2, 2024
Merged

Added dynamic user details #22

merged 4 commits into from May 2, 2024

Conversation

Satendra-SR
Copy link
Member

@Satendra-SR Satendra-SR commented Apr 30, 2024 •
edited by Sachinbisht27

#16

Please complete the following steps and check these boxes before filing your PR:

Types of changes

  • Bug fix (a change which fixes an issue)
  • New feature (a change which adds functionality)

Short description of what this resolves:

  1. Fixed PR template
  2. Refactored user creation
  3. made use details dynamic while capturing indicators

Checklist:

  • I have performed a self-review of my own code.
  • The code follows the style guidelines of this project.
  • The code changes are passing the CI checks
  • I have documented my code wherever required.
  • The changes requires a change to the documentation.
  • I have updated the documentation based on the my changes.
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.\

@Satendra-SR Satendra-SR marked this pull request as ready for review May 1, 2024 14:08
@Sachinbisht27 Sachinbisht27 self-requested a review May 2, 2024 03:33
Sachinbisht27
Sachinbisht27 approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@Sachinbisht27 Sachinbisht27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and the changes are working fine. Approved.

@Sachinbisht27 Sachinbisht27 merged commit 931a0be into develop May 2, 2024
1 check passed
@Sachinbisht27 Sachinbisht27 deleted the feature/16/user-details-dynamic-data branch May 2, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachinbisht27 Sachinbisht27 Sachinbisht27 approved these changes

Assignees

@Satendra-SR Satendra-SR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Satendra-SR @Sachinbisht27