Detects when a MemberExpression returns null and adjusts it as a ConstantExpression #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tantExpression Neo4j doesn't consider null as valid values for PropertyBags (relationships and nodes). Neo4jClient could have a MemberExpression in a Where() construct and it could detect it if was in reality a ConstantExpression, however it just sends the value as parameter regardless if it's a null value. This commit fixes that by having the same behavior that occurs in VisitConstant(ConstantExpression) if it detects a null value.
| } | ||
| else | ||
| { | ||
| TextOutput.Remove(TextOutput.ToString().LastIndexOf(lastWrittenMemberName, StringComparison.Ordinal), lastWrittenMemberName.Length); |
There was a problem hiding this comment.
This logic branch isn't tested.
The unit tests from the last commit was moved from the CypherFluentQueryWhereTests to CypherWhereExpressionBuilderTests and added three more unit tests for all logic branches within this method.
|
I added the missing unit tests. |
tathamoddie
added a commit
that referenced
this pull request
Mar 6, 2014
Detects when a MemberExpression returns null and adjusts it as a ConstantExpression
|
This will be automatically deployed to NuGet in about 60 seconds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neo4j doesn't consider null as valid values for PropertyBags
(relationships and nodes).
Neo4jClient could have a MemberExpression in a Where() construct and it
could detect it if was in reality a ConstantExpression, however it just
sends the value as parameter regardless if it's a null value.
This commit fixes that by having the same behavior that occurs in
VisitConstant(ConstantExpression) if it detects a null value.