Visual Basic support #15
Conversation
|
I guess file renames wiped all file history but there is nothing to do there 😞 looks good to me. |
|
Must be a GitHub limitation of anything. Git itself has no trouble tracking files through the rename here, even for operations like rebase. |
|
I cannot seem to get it working when I F5 to test it inside the experimental hive:
Am I doing something wrong? |
|
It seems that the problem is the node target. It only sees the node as
I would assume to get the refactoring suggestion when my cursor is around the parameter name as below but the node seems to be the
|
| ' Note: If I can find the nameof feature in VB.net, then I'll change this line to reflect that | ||
| Dim _paramname_ = SyntaxFactory.StringLiteralExpression( | ||
| SyntaxFactory.StringLiteralToken("""" & parameterStmt.Identifier.Identifier.Text & """", | ||
| parameterStmt.Identifier.Identifier.Text)) |
There was a problem hiding this comment.
do we have nameof operator in VB?
There was a problem hiding this comment.
I would suggest making this a follow-up issue.
|
Is there anything here that still needs to be fixed prior to the initial "merge"? Since the request contains file moves it helps to include it early so people can work from a new reference point. |
|
@sharwell Can we do something for this (I have no idea if it's safe to watch for It seems pretty annoying but if this is the way it should be, |
|
If the behavior is unintuitive we can file a separate issue. |
|
That's fine, I'm getting it in then. I will open up the issues as well. |
This pull request adds the Visual Basic support implemented by @AdamSpeight2008. Fixes #6.