Improve test coverage for shared pools

DotNetAnalyzers · Nov 8, 2019 · 27b044d · 27b044d
1 parent 58a3ca4
commit 27b044d
Showing 1 changed file with 16 additions and 2 deletions.
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.Test/HelperTests/ObjectPools/SharedPoolsTests.cs b/StyleCop.Analyzers/StyleCop.Analyzers.Test/HelperTests/ObjectPools/SharedPoolsTests.cs
@@ -211,17 +211,31 @@ public void TestClearAndFreeLarge()
         [Fact]
         public void TestPooledObjectHandlesNullAllocation()
         {
-            object Allocator(ObjectPool<object> pool)
+            object NullAllocator(ObjectPool<object> pool)
                 => null;
 
+            object NonNullAllocator(ObjectPool<object> pool)
+                => new object();
+
+            bool releaserCalled = false;
             void Releaser(ObjectPool<object> pool, object obj)
             {
+                releaserCalled = true;
             }
 
-            using (var obj = new PooledObject<object>(SharedPools.Default<object>(), Allocator, Releaser))
+            using (var obj = new PooledObject<object>(SharedPools.Default<object>(), NullAllocator, Releaser))
             {
                 Assert.Null(obj.Object);
             }
+
+            Assert.False(releaserCalled);
+
+            using (var obj = new PooledObject<object>(SharedPools.Default<object>(), NonNullAllocator, Releaser))
+            {
+                Assert.NotNull(obj.Object);
+            }
+
+            Assert.True(releaserCalled);
         }
     }
 }