Fix SX1309(S)

DotNetAnalyzers · Sep 1, 2019 · d1aad56 · d1aad56
1 parent 6f22a70
commit d1aad56
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 7 deletions.
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/NamingRules/NamingResources.Designer.cs b/StyleCop.Analyzers/StyleCop.Analyzers/NamingRules/NamingResources.Designer.cs
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers/NamingRules/NamingResources.resx b/StyleCop.Analyzers/StyleCop.Analyzers/NamingRules/NamingResources.resx
@@ -274,12 +274,21 @@
     <value>Tuple element names should use correct casing</value>
   </data>
   <data name="SX1309Description" xml:space="preserve">
-    <value>A static field name in C# does not begin with an underscore.</value>
+    <value>A field name in C# does not begin with an underscore.</value>
   </data>
   <data name="SX1309MessageFormat" xml:space="preserve">
+    <value>Field '{0}' should begin with an underscore</value>
+  </data>
+  <data name="SX1309SDescription" xml:space="preserve">
+    <value>A static field name in C# does not begin with an underscore.</value>
+  </data>
+  <data name="SX1309SMessageFormat" xml:space="preserve">
     <value>Static field '{0}' should begin with an underscore</value>
   </data>
-  <data name="SX1309Title" xml:space="preserve">
+  <data name="SX1309STitle" xml:space="preserve">
     <value>Static field names should begin with underscore</value>
   </data>
+  <data name="SX1309Title" xml:space="preserve">
+    <value>Field names should begin with underscore</value>
+  </data>
 </root>
diff --git a/...nalyzers/StyleCop.Analyzers/NamingRules/SX1309SStaticFieldNamesMustBeginWithUnderscore.cs b/...nalyzers/StyleCop.Analyzers/NamingRules/SX1309SStaticFieldNamesMustBeginWithUnderscore.cs
@@ -35,9 +35,9 @@ internal class SX1309SStaticFieldNamesMustBeginWithUnderscore : DiagnosticAnalyz
         /// </summary>
         public const string DiagnosticId = "SX1309S";
         private const string HelpLink = "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SX1309S.md";
-        private static readonly LocalizableString Title = new LocalizableResourceString(nameof(NamingResources.SX1309Title), NamingResources.ResourceManager, typeof(NamingResources));
-        private static readonly LocalizableString MessageFormat = new LocalizableResourceString(nameof(NamingResources.SX1309MessageFormat), NamingResources.ResourceManager, typeof(NamingResources));
-        private static readonly LocalizableString Description = new LocalizableResourceString(nameof(NamingResources.SX1309Description), NamingResources.ResourceManager, typeof(NamingResources));
+        private static readonly LocalizableString Title = new LocalizableResourceString(nameof(NamingResources.SX1309STitle), NamingResources.ResourceManager, typeof(NamingResources));
+        private static readonly LocalizableString MessageFormat = new LocalizableResourceString(nameof(NamingResources.SX1309SMessageFormat), NamingResources.ResourceManager, typeof(NamingResources));
+        private static readonly LocalizableString Description = new LocalizableResourceString(nameof(NamingResources.SX1309SDescription), NamingResources.ResourceManager, typeof(NamingResources));
 
         private static readonly DiagnosticDescriptor Descriptor =
             new DiagnosticDescriptor(DiagnosticId, Title, MessageFormat, AnalyzerCategory.NamingRules, DiagnosticSeverity.Warning, AnalyzerConstants.DisabledAlternative, Description, HelpLink);