Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA1027 (TabsMustNotBeUsed) code fix ignores trivia #1246

Closed
Maxwe11 opened this issue Aug 19, 2015 · 6 comments · Fixed by #1466
Closed

SA1027 (TabsMustNotBeUsed) code fix ignores trivia #1246

Maxwe11 opened this issue Aug 19, 2015 · 6 comments · Fixed by #1466
Assignees
Milestone

Comments

@Maxwe11
Copy link
Member

Maxwe11 commented Aug 19, 2015

e.g. assume all lines indented by tabs

    /// <summary>
    /// foo bar
    /// </summary>
    public void FooBar()

after code fix we will receive:

    /// <summary>
    /// foo bar
    /// </summary>
    public void FooBar()

code indented by spaces but documentation still indented by tabs

@Maxwe11
Copy link
Member Author

Maxwe11 commented Aug 19, 2015

same issue with tabs inside comments

@robinsedlaczek
Copy link
Contributor

Working on it!

Question: which points from the contributing guide are important for bug fixes in existing analyzers and code fixes? How should my branch be named?

@sharwell
Copy link
Member

sharwell commented Sep 1, 2015

@robinsedlaczek I wrote the contributing guide back when only I was working on the project. It could be entirely out of date now that the project took off. The comment you posted is enough to count as claiming it. Then there is a code review after you submit a pull request. 😄

@robinsedlaczek
Copy link
Contributor

@sharwell Cool, thanks!

@sharwell sharwell added this to the 1.0.0 Beta 12 milestone Sep 13, 2015
@sharwell sharwell self-assigned this Sep 13, 2015
@sharwell
Copy link
Member

@robinsedlaczek I ended up fixing this as part of another efficiency change I was working on.

@robinsedlaczek
Copy link
Contributor

@sharwell Oh, so I am too late. :) Great, that you fixed it. I'll have a look to learn. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants