Code fix for SA1025 (multiple whitespace) conflicts with SA1008/SA1009 (parenthesis spacing)

[otac0n]

The code fix for SA1025 is shown in this scenario:

typeof(   string   )

Ideally, only the SA1008 and SA1009 code fixes would be presented. Using the SA1025 code fix here leaves the SA1008 and SA1009 warnings around. The user gets very little indication that there were actually two violations.

This is not that bad of a user experience, but it is confusing to have to fix the same spacing twice (even for different reasons). It makes it feel (to the user) like the code fix itself is broken. I was trying to demo this to my team, and it looked like a hiccup.

The SA1008 or SA1009 fixes also fix SA1025 automatically, of course.

[sharwell]

I really want to close this as won't fix because no one writes code like that (and technically the fixes do work even if they did), but I'll wait for a second opinion on that. 😑

[otac0n]

That's completely fair. I just wanted to register it as a concern. I do demo SyleCop.Analyzers like that, for what it's worth.

[sharwell]

Marked as up for grabs.