SA1133 batch code fix does half the work

[vbfox]

Given the following code (Using the JetBrains.Annotations NuGet package):

using JetBrains.Annotations;

namespace Stylecop_rc1_bug_repro
{
    class Foo
    {
        [CanBeNull, UsedImplicitly(ImplicitUseKindFlags.Assign)]
        public string Foo1{ get; set; }

        [CanBeNull, UsedImplicitly(ImplicitUseKindFlags.Assign)]
        public string Foo2{ get; set; }

        [CanBeNull, UsedImplicitly(ImplicitUseKindFlags.Assign)]
        public string Foo3 { get; set; }

        [CanBeNull, UsedImplicitly(ImplicitUseKindFlags.Assign)]
        public string Foo4{ get; set; }

        [CanBeNull, UsedImplicitly(ImplicitUseKindFlags.Assign)]
        public string Foo5{ get; set; }

        [CanBeNull, UsedImplicitly(ImplicitUseKindFlags.Assign)]
        public string Foo6{ get; set; }

        [CanBeNull, UsedImplicitly(ImplicitUseKindFlags.Assign)]
        public string Foo7{ get; set; }

        [CanBeNull, UsedImplicitly(ImplicitUseKindFlags.Assign)]
        public string Foo8{ get; set; }

    }
}

Applying SA1133 code fix on document scope give :

using JetBrains.Annotations;

namespace Stylecop_rc1_bug_repro
{
    class Foo
    {
        [CanBeNull]
        [UsedImplicitly(ImplicitUseKindFlags.Assign)]
        public string Foo1 { get; set; }

        [CanBeNull, UsedImplicitly(ImplicitUseKindFlags.Assign)]
        public string Foo2 { get; set; }

        [CanBeNull]
        [UsedImplicitly(ImplicitUseKindFlags.Assign)]
        public string Foo3 { get; set; }

        [CanBeNull, UsedImplicitly(ImplicitUseKindFlags.Assign)]
        public string Foo4 { get; set; }

        [CanBeNull]
        [UsedImplicitly(ImplicitUseKindFlags.Assign)]
        public string Foo5 { get; set; }

        [CanBeNull, UsedImplicitly(ImplicitUseKindFlags.Assign)]
        public string Foo6 { get; set; }

        [CanBeNull]
        [UsedImplicitly(ImplicitUseKindFlags.Assign)]
        public string Foo7 { get; set; }

        [CanBeNull]
        [UsedImplicitly(ImplicitUseKindFlags.Assign)]
        public string Foo8 { get; set; }

    }
}

(VS2015 update 1, StyleCop 1.0 RC1)

[vbfox]

BTW Running the code fix a second time finishes the work cleanly.

[sharwell]

Assigning to 1.0 for investigation, but I expect this will end up as a post-1.0 improvement.

/cc @vweijsters

[NikolayIT]

I am just guessing here but I have a good feeling that fixing #1878 will also fix this issue.

[pdelvo]

@vweijsters Are you workin on this? If not I would like to grab this.

@vweijsters @sharwell Do we want to include this is rc2? My fix would be to write a custom fix all provider. That would also improve performance.

[sharwell]

Normally I would say no, but we've already had a bug report (on gitter I think) regarding the performance of this code fix. If the current fix is easily converted to support a custom fix all then I think we could include it.