Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SA1205 (PartialElementsMustDeclareAccess) underlines entire partial class instead of just the 1-line declaration #714

Closed
AArnott opened this issue Apr 26, 2015 · 4 comments · Fixed by #722
Closed

SA1205 (PartialElementsMustDeclareAccess) underlines entire partial class instead of just the 1-line declaration #714

AArnott opened this issue Apr 26, 2015 · 4 comments · Fixed by #722
Assignees
@vweijsters
Labels
bug fixed
Milestone
1.0.0 Alpha 6

Comments

@AArnott
Copy link
Contributor

AArnott commented Apr 26, 2015

Give a very large class that is missing an access modifier, this rule squiggles the entire class definition (methods, bodies, everything).

partial class Foo
{
}

It should only squiggle the first line, or just part of the first line.
@sharwell sharwell added the bug label Apr 26, 2015
@sharwell sharwell added this to the 1.0.0 Alpha 6 milestone Apr 26, 2015
@sharwell sharwell changed the title SA1205 underlines entire partial class instead of just the 1-line declaration SA1205 (PartialElementsMustDeclareAccess) underlines entire partial class instead of just the 1-line declaration Apr 26, 2015
@sharwell
Copy link
Member

In your example, it should underline only the identifier Foo.

@sharwell
Copy link
Member

@vweijsters Do you want to take this one?

@vweijsters
Copy link
Contributor

Yup, I'll grab this one

@vweijsters
Copy link
Contributor

Having #625 would really help for testing this

vweijsters added a commit to vweijsters/StyleCopAnalyzers that referenced this issue Apr 26, 2015
@vweijsters
Fixes DotNetAnalyzers#714
47d60ac
@vweijsters vweijsters mentioned this issue Apr 26, 2015
Merged
sharwell added a commit that referenced this issue Apr 26, 2015
@sharwell
Merge pull request #722 from vweijsters/fix-714
c6fede8 
Fix for issue #714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vweijsters vweijsters

Labels
bug fixed
Projects
None yet
Milestone
1.0.0 Alpha 6
Development

Successfully merging a pull request may close this issue.

Fix for issue #714 vweijsters/StyleCopAnalyzers
3 participants
@AArnott @sharwell @vweijsters