Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of <include> elements in documentation #1898

Merged
merged 1 commit into from
Dec 4, 2015
Merged

Fix handling of <include> elements in documentation #1898

merged 1 commit into from
Dec 4, 2015

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Dec 4, 2015

This change only updates SA1604, SA1606, and SA1615 to properly handle
these comments.

Fixes #1603

@sharwell sharwell added this to the 1.0.0 RC 2 milestone Dec 4, 2015
@codecov-io
Copy link

Current coverage is 79.38%

Merging #1898 into stabilization will not affect coverage as of efdfd3b

@@            stabilization   #1898   diff @@
=============================================
  Files                 558     559     +1
  Stmts               34852   35013   +161
  Branches             9657    9689    +32
  Methods                                 
=============================================
+ Hit                 27667   27794   +127
- Partial              5643    5656    +13
- Missed               1542    1563    +21

Review entire Coverage Diff as of efdfd3b

Powered by Codecov. Updated on successful CI builds.

pdelvo
pdelvo reviewed Dec 4, 2015
View reviewed changes
StyleCop.Analyzers/StyleCop.Analyzers.Test/DocumentationRules/SA1604UnitTests.cs
using TestHelper;
using Xunit;

/// <summary>
/// This class contains unit tests for <see cref="SA1604ElementDocumentationMustHaveSummary"/>.
/// </summary>
/// <include file='../../StyleCop.Analyzers.ruleset' path='/Class1/Foo/*'/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not.

@pdelvo
Copy link
Member

pdelvo commented Dec 4, 2015

Otherwise 👍

@sharwell
Fix handling of <include> elements in documentation
cd7b0db 
This change only updates SA1604, SA1606, and SA1615 to properly handle
these comments.

Fixes DotNetAnalyzers#1603
@vweijsters
Copy link
Contributor

👍

@sharwell sharwell merged commit cd7b0db into DotNetAnalyzers:stabilization Dec 4, 2015
sharwell added a commit that referenced this pull request Dec 4, 2015
@sharwell
Merge pull request #1898 from sharwell/fix-1603
35c0aff 
Fix handling of <include> elements in documentation
@sharwell sharwell deleted the fix-1603 branch December 4, 2015 21:49
@sharwell sharwell mentioned this pull request Dec 4, 2015
Closed
@sharwell sharwell mentioned this pull request May 28, 2018
Closed
@sharwell sharwell mentioned this pull request Aug 14, 2018
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pdelvo pdelvo

Labels
None yet
Projects
None yet
Milestone
1.0.0 RC 2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sharwell @codecov-io @pdelvo @vweijsters