Fix handling of trivia before first using directive #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
force-pushed
the
fix-using-trivia
branch
2 times, most recently
from
1c74e8f
to
42bbb42
Compare
Codecov Report
@@ Coverage Diff @@
## master #2435 +/- ##
==========================================
+ Coverage 97.14% 97.17% +0.03%
==========================================
Files 732 732
Lines 94107 94425 +318
Branches 3449 3468 +19
==========================================
+ Hits 91417 91756 +339
+ Misses 1834 1811 -23
- Partials 856 858 +2
Continue to review full report at Codecov.
|
sharwell
force-pushed
the
fix-using-trivia
branch
from
42bbb42
to
49986c4
Compare
When a comment preceding a set of using directives is separated from the first using directive by a blank line, that comment is associated with the list of using directives as opposed to specifically tied to the first one. This means after reordering the separated comment will continue to be separated and placed before the first using directive of the sorted result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2363
Also fixes a few other subtle bugs revealed during testing.