Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue in SA1130 code fix with parameterless delegates. #3020

Merged
merged 2 commits into from Sep 20, 2019
Merged

Fix issue in SA1130 code fix with parameterless delegates. #3020

merged 2 commits into from Sep 20, 2019

Conversation

vweijsters
Copy link
Contributor

Fixes #2997

sharwell
sharwell previously approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this or with the alternative mentioned in review, whichever turns out cleaner.

StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/ReadabilityRules/SA1130CodeFixProvider.cs Outdated Show resolved Hide resolved
@vweijsters vweijsters merged commit 813c615 into DotNetAnalyzers:master Sep 20, 2019
@vweijsters vweijsters deleted the fix-2997 branch September 20, 2019 19:09
@sharwell sharwell added this to the 1.2-beta.next milestone Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0-beta.113
Development

Successfully merging this pull request may close these issues.

NullReferenceException on SA1130 CodeFix
2 participants
@vweijsters @sharwell