Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create markdown-links-verifier.yml #3318

Closed
wants to merge 2 commits into from

Conversation

Youssef1313
Copy link
Contributor

@Youssef1313 Youssef1313 commented Mar 14, 2021

Results:

2021-03-14T08:50:50.5687158Z Validating links in: /github/workspace/documentation/SA1305.md.
2021-03-14T08:50:50.5694186Z ##[error]Invalid link: 'Images/HungarianSettings.JPG' relative to '/github/workspace/documentation'.

The GitHub Action wasn't run in the PR, only in my fork. This is probably due GitHub Actions being disabled in the repository?
If you don't want to enable this GH Action, let's fix the broken image only.

@Youssef1313
Copy link
Contributor Author

The image is most probably existed only when the docs where at http://www.stylecop.com/docs/SA1305.html.

@Youssef1313
Copy link
Contributor Author

Found a version of the image here.

@sharwell Is the image still relevant?

@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #3318 (600707b) into master (fdb3d67) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3318   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files        1021     1021           
  Lines      110375   110375           
  Branches     3813     3813           
=======================================
  Hits       103237   103237           
  Misses       6179     6179           
  Partials      959      959           

@sharwell
Copy link
Member

The image is not still relevant.

@Youssef1313
Copy link
Contributor Author

@sharwell I deleted the image and updated the documentation. Let me know if you don't want to use the GH Action to delete it.

@@ -0,0 +1,14 @@
name: Markdown links verifier
Copy link
Member

@sharwell sharwell Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 For now I'd prefer to not add the action. Can you resubmit just the fixed documentation file as a separate PR? This one can stay closed so future reviewers are aware of its existence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants