Support C# 10 'record struct' #3401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharwell
force-pushed
the
record-struct
branch
from
88a4372
to
bb5a687
Compare
Codecov Report
@@ Coverage Diff @@
## master #3401 +/- ##
==========================================
- Coverage 93.45% 93.09% -0.37%
==========================================
Files 1030 1038 +8
Lines 111283 111809 +526
Branches 3946 3969 +23
==========================================
+ Hits 104000 104089 +89
- Misses 6267 6702 +435
- Partials 1016 1018 +2 |
sharwell
force-pushed
the
record-struct
branch
from
bb5a687
to
22d1715
Compare
20 tasks
NickCraver
added a commit
to NickCraver/azure-functions-host
that referenced
this pull request
Dec 1, 2021
Part of Azure#7908. This is a contention hot path under load for 2 reasons: allocations on each key access (start and end of each event) and the `Monitor.Wait()` around the update portion of `.AddOrUpdate()`. There's also a string replication which isn't used on the `Data` string itself, but that's upstream and will pitch it in another PR. This change overall: optimizes the key access using a `readonly record struct` (for fast hashing), `Lazy<T>` (so we don't lose initial metrics), and moves the update outside of the dictionary path since each of the attributes on a metric are atomicly viable. Note though, this breaks StyleCop sporadically - before this can go in we'd need to update StyleCop and pull in DotNetAnalyzers/StyleCopAnalyzers#3401 which will be in the next 1.2.x beta. I've pinged Sam about getting a release there we can use.
liliankasem
pushed a commit
to Azure/azure-functions-host
that referenced
this pull request
Feb 24, 2023
Part of #7908. This is a contention hot path under load for 2 reasons: allocations on each key access (start and end of each event) and the `Monitor.Wait()` around the update portion of `.AddOrUpdate()`. There's also a string replication which isn't used on the `Data` string itself, but that's upstream and will pitch it in another PR. This change overall: optimizes the key access using a `readonly record struct` (for fast hashing), `Lazy<T>` (so we don't lose initial metrics), and moves the update outside of the dictionary path since each of the attributes on a metric are atomicly viable. Note though, this breaks StyleCop sporadically - before this can go in we'd need to update StyleCop and pull in DotNetAnalyzers/StyleCopAnalyzers#3401 which will be in the next 1.2.x beta. I've pinged Sam about getting a release there we can use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3384
Fixes #3395