Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SA1015 analyzer to handle generic attributes (c# 11 preview) #3494

Merged

Conversation

bjornhellander
Copy link
Contributor

Fixes #3487

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #3494 (0d459d4) into master (4fba7cd) will increase coverage by 3.56%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3494      +/-   ##
==========================================
+ Coverage   89.67%   93.24%   +3.56%     
==========================================
  Files        1014     1066      +52     
  Lines      108131   113345    +5214     
  Branches     4000     4003       +3     
==========================================
+ Hits        96971   105691    +8720     
+ Misses      10027     6624    -3403     
+ Partials     1133     1030     -103     

@bjornhellander
Copy link
Contributor Author

On hold until the c# 11 test project is on master

@sharwell
Copy link
Member

sharwell commented May 2, 2022

@bjornhellander I believe this can be rebased now to simplify the review

@sharwell sharwell merged commit e017492 into DotNetAnalyzers:master May 3, 2022
@sharwell sharwell added this to the 1.2-beta.next milestone May 3, 2022
@bjornhellander bjornhellander deleted the feature/genericattribute branch May 3, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SA1015 in generic attribute [MyAttribute<int>]
2 participants