Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore .devcontainer DockerFiles in cake builds. #1737

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Ignore .devcontainer DockerFiles in cake builds. #1737

merged 3 commits into from
Aug 18, 2022

Conversation

ElanHasson
Copy link
Contributor

@ElanHasson ElanHasson commented Aug 12, 2022 •
edited
Loading

Currently if you use a Dev Container, the cake build picks it up.

Resolves #1704

@github-actions github-actions bot added template/Orleans The Microsoft Orleans project template template/API The Swagger API project template labels Aug 12, 2022
@ElanHasson
Copy link
Contributor Author

@RehanSaeed this is ready for you!

@RehanSaeed RehanSaeed added the minor Pull requests requiring a minor version update according to semantic versioning. label Aug 18, 2022
@RehanSaeed
Copy link
Member

Thank you for your contribution

@RehanSaeed RehanSaeed merged commit 9a157b9 into Dotnet-Boxed:main Aug 18, 2022
@ElanHasson ElanHasson deleted the patch-2 branch August 18, 2022 13:36
@ElanHasson
Copy link
Contributor Author

Thank you for your contribution

Thank you @RehanSaeed for all of your hard work.

You should drop in on the Orleans Discord, I'd love to chat for a bit.

@RehanSaeed
Copy link
Member

Feel free to ping me on Twitter or my email address you can find on rehansaeed.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RehanSaeed RehanSaeed RehanSaeed left review comments

Assignees
No one assigned
Labels
minor Pull requests requiring a minor version update according to semantic versioning. template/API The Swagger API project template template/Orleans The Microsoft Orleans project template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Donet Cake DockerBuild does not fail the GH action step
2 participants
@ElanHasson @RehanSaeed