Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cake Publish Task Should Only Publish Source Projects #840

Merged
merged 1 commit into from Nov 4, 2020

Conversation

RehanSaeed
Copy link
Member

@RehanSaeed RehanSaeed commented Nov 4, 2020

Fixes #818

@RehanSaeed RehanSaeed added template/GraphQL The GraphQL project template template/API The Swagger API project template template/Orleans The Microsoft Orleans project template patch Pull requests requiring a patch version update according to semantic versioning. labels Nov 4, 2020
@RehanSaeed RehanSaeed merged commit 924c344 into master Nov 4, 2020
@RehanSaeed RehanSaeed deleted the fix-cake-publish branch November 4, 2020 14:28
{
DotNetCorePublish(
".",
project.ToString(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will this do if you have class libraries here that are not publishable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Source folder? It will try to publish them. If you don't want that you can edit this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We know the name of the project file, and most people aren't publishing multiple web projects. Why not just publish the main project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Pull requests requiring a patch version update according to semantic versioning. template/API The Swagger API project template template/GraphQL The GraphQL project template template/Orleans The Microsoft Orleans project template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible issue with Web.Config
2 participants