Compatibility bug: SparkHammer

[drakray]

Using SparkHammer with D3Core(and Lumberjack) make some Hammer crash in anvil, and some Lumberaxe and Hammer to randomly become unavailable

Related crash here

[dries007]

More then likely this line need an extra null check.

D3Core/src/main/java/net/doubledoordev/d3core/util/Materials.java

Line 109 in 5503e61

if (stack == ItemStack.EMPTY || material.getRepairItemStack() != ItemStack.EMPTY) continue;

I'll look at it properly when I'm home though.

[drakray]

From my log, seems like SH use a HammerMaterial format for their stuff, no underscore

[dries007]

Likely irrelevant, the issue seems to be that sometimes the repairmaterial stack gets set to null, which is no longer a valid stack for inventories (although none said it can't be for repair materials, but I'll go with them on this.)

[dries007]

@drakray Would you mind testing the latest build?
https://jenkins.dries007.net/job/D3Core/

[drakray]

Could start, I got a Missing dependency Forge: any, using Forge 2255
http://pastebin.com/WgZ6RRQR
line 69? http://pastebin.com/CSvUFEEc

[dries007]

fixed that, could you try build 65?

[drakray]

got a crash that I think was caused by my materials.json, trying without it

[drakray]

Other than that, it seems that everything work correctly, I must just fix my materials.json

[dries007]

Alright, let me know if you find something that doesn't seem right. We'll upload the build to curse in the next couple of hours.

[drakray]

just some weird stuff caused by "dynamic create lumberaxe", because some mod set weird repair material, like ironBlock for GiantHammer, dirt?, stair or nether star??, I dont know which mod does that, but it's weird lol
Either way, the SparkHammer compat bug seems fixed

[dries007]

Unfortunately you can't override them anymore. (Forge doesn't allow that.) You'll have to talk to the mod devs about that.

[drakray]

in my materials.json, I just make 3 for Botania, and all FunOres because they don't add tools, so they don't set materials, and I like having Osmium tool(sooo durable :D )

I use to set BaseMetal materials, but it's not 1.11.2 so

[drakray]

Could there be a way to get which material from the json file is responsible for a crash related to trying to overwrite, show up in the crashlog?

[Claycorp]

Check the latest log. It should spit out a message with all the information.

[drakray]

I found it, just had to search for FATAL and I found it quickly lol