Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with upcoming paradox CRAN release #195

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

mb706
Copy link
Contributor

@mb706 mb706 commented May 27, 2024

Description

Use version-agnostic paradox UI to prepare for new CRAN release: Instead of ParamDbl, ParamInt objects, create ParamSets using ps(param_id = p_int(...)).

Reference to Issues or PRs

#194

Comments

CI checks that use the 'dev' version of mlr3 now also use the dev-version of paradox; you can choose to remove this once paradox 1.0.0 is on CRAN.

PR Checklist

Please fill out this PR checklist (see our contributing guidelines for details).

  • The title of the pull request summarizes the changes made.
  • The PR contains a detailed description of all changes and additions.
  • References to related issues or PRs are added.
  • The code passes R CMD check and all (unit) tests (see our contributing guidelines for details).
  • Enhancements or new feature are equipped with unit tests.
  • The changes adhere to the "mlr-style" standards (see our contributing guidelines for details).

@PhilippBach
Copy link
Member

I'm merging this PR now for some additional checks to p-paradox... I'll close the issue once the changes are merged to main... Thanks for your help so far!

@PhilippBach PhilippBach merged commit ba1836d into DoubleML:p-paradox Jun 5, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants