Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A nearly working version #1

Merged
merged 1 commit into from
Mar 5, 2020
Merged

A nearly working version #1

merged 1 commit into from
Mar 5, 2020

Conversation

istreeter
Copy link

Good things:

  • The example page displays the editor
  • Think I've properly handled mount/unmount hooks, and the possibility of having multiple components on the same page.
  • Updated a bunch of dependencies to the latest version, mainly because it made it easier to read documentation.

Bad things:

  • Not yet managed to get rollup to include jsme in the bundle. Instead I have added a <script src="jsme.js"> tag to the index.html in the example app.

@istreeter
Copy link
Author

Btw I think you will not persuade any build tool to include the jsme files, because they import other fiels by creating script elements on the page and setting src="someOtherFile.js" -- I think that is completely incompatible with bundlers.

Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@danyx23 danyx23 merged commit 5e0288c into master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants