Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker的 vertical align导致某些情况下 对不齐 #1561

Closed
1 task done
iktsuarpok-luo opened this issue Apr 19, 2023 · 5 comments · Fixed by #1609
Closed
1 task done

DatePicker的 vertical align导致某些情况下 对不齐 #1561

iktsuarpok-luo opened this issue Apr 19, 2023 · 5 comments · Fixed by #1609

Comments

@iktsuarpok-luo
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Which Component

DatePicker

Semi Version

2

Current Behavior

semi2 DatePick新增了vertical-align: top; 属性,导致在外层有更高高度且设置 align-items: center;的情况下,semi1可以保证居中对齐,但semi2 datepick靠上

Expected Behavior

No response

Steps To Reproduce

No response

ReproducibleCode

<div style={{lineHeight: "42px";alignItems: "center"}}>
    <Select/>
    <DatePicker/>
    <Select/>
</div>

Environment

- OS:
- browser:

Anything else?

No response

@pointhalo
Copy link
Collaborator

@shijiatongxue 看下这个问题,vertical-align:是必须的吗?

@shijiatongxue
Copy link
Collaborator

这个代码好像无法复现这个问题?

@shijiatongxue
Copy link
Collaborator

这个代码好像无法复现这个问题?

semi 1

image

semi2

image

@pointhalo pointhalo changed the title [BUG] <title>DatePicker对不齐 DatePicker的 vertical align导致某些情况下 对不齐 Apr 20, 2023
@pointhalo
Copy link
Collaborator

补充一下复现 Demo. 在 父级 display flex 且 aligenItems center时的展示会受影响

import React from 'react';
import { DatePicker, Select } from '@douyinfe/semi-ui';
() => {
    return (
        <div style={{lineHeight: "42px", aligenItems: "center", display: "flex"}}>
            <div><Select/></div>
            <div><DatePicker type="dateRange"/></div>
            <div><Select/></div>
        </div>
    )
}

pointhalo pushed a commit that referenced this issue May 17, 2023
Co-authored-by: shijia.me <shijia.me@bytedance.com>
@shijiatongxue
Copy link
Collaborator

2.36.0-beta.0 fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants