Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [form] Fixed import type ScrollIntoViewOptions name #1713

Merged
merged 1 commit into from Jul 19, 2023

Conversation

rashagu
Copy link
Contributor

@rashagu rashagu commented Jul 19, 2023

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe: Type name case

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Fix: 修复导入类型ScrollIntoViewOptions首字母大小写。 引入时是首字母小写,但是有个地方用了大写,某些新版本的ts会报错

🇺🇸 English

  • Fix: Fixed import type ScrollIntoViewOptions uppercase and lowercase. It is introduced with the first letter in lower case, but it is capitalized in one place, and some newer versions of ts will report an error

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bae4ac2:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (c3a9f82) 88.09% compared to head (e378fe3) 88.07%.

❗ Current head e378fe3 differs from pull request most recent head bae4ac2. Consider uploading reports for the commit bae4ac2 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1713      +/-   ##
==========================================
- Coverage   88.09%   88.07%   -0.02%     
==========================================
  Files         433      433              
  Lines       25206    25206              
  Branches     6350     6350              
==========================================
- Hits        22206    22201       -5     
- Misses       3000     3005       +5     
Impacted Files Coverage Δ
packages/semi-foundation/form/foundation.ts 87.35% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pointhalo pointhalo merged commit 1739f1c into DouyinFE:main Jul 19, 2023
8 checks passed
pointhalo added a commit that referenced this pull request Jul 19, 2023
@pointhalo
Copy link
Collaborator

v2.39.2 已 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants